fix(js_semantic_model): handle bogus conditional type #2619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1695
Our semantic model defers the binding of
infer T
once the scope of the true branch of a conditional type is defined.However, we miss an edge case: when the true branch is absent,
infer T
is never bound.This leads to the error observed in #1695, where
noUnusedVariables
tries to obtain the undefined binding ofinfer T
.To solve the issue I added a fallback: if the true branch is absent, we bind the
infer
declarations in the scope of the conditional type.Test Plan
I added a non-regression test.