fix(lint/noRedeclare): handle function and call overloads #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
Conaclos
commented
Apr 26, 2024
| @@ -137,6 +137,7 @@ impl AnyJsBindingDeclaration { | |||
| | AnyJsBindingDeclaration::TsModuleDeclaration(_) | |||
| | AnyJsBindingDeclaration::TsTypeParameter(_), | |||
| AnyJsBindingDeclaration::JsFunctionDeclaration(_) | |||
| | AnyJsBindingDeclaration::JsFunctionExportDefaultDeclaration(_) | |||
There was a problem hiding this comment.
This change fixes #2372
Conaclos
commented
Apr 26, 2024
| @@ -334,6 +335,7 @@ impl SemanticEventExtractor { | |||
| | TS_TYPE_ALIAS_DECLARATION | |||
| | TS_DECLARE_FUNCTION_DECLARATION | |||
| | TS_DECLARE_FUNCTION_EXPORT_DEFAULT_DECLARATION | |||
| | TS_CALL_SIGNATURE_TYPE_MEMBER | |||
There was a problem hiding this comment.
This change fixes #2608 by creating a scope for every call signature.
Conaclos
commented
Apr 26, 2024
Comment on lines
+139
to
+147
| if let Some(function_scope) = scope.parent() { | ||
| for binding in function_scope.bindings() { | ||
| let id_binding = binding.tree(); | ||
| if let Some(decl) = id_binding.declaration() { | ||
| let name = id_binding.text(); | ||
| declarations.insert(name, (id_binding.syntax().text_trimmed_range(), decl)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I fixed #2394 by adding every parameter and every type parameter in declarations.
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #2615 will improve performances by 7.09%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2608
Fix #2394
Fix #2372
Test Plan
I added a non-regression test for each issue.