feat(biome_css_analyzer): noUnknownUnit

[neoki07]

Summary

close #2515
Implement unit-no-unknown

However, the stylelint options ignoreUnits and ignoreFunctions are not implemented.

Test Plan

added tests and snapshots

[neoki07]

I have brought stylelint tests (link). However, root { --margin: 10px + 10pix; } was not added because the syntax seems incorrect.

[neoki07]

I have brought stylelint tests (link). However, @font-face { unicode-range: U+0100-024F; } was not added because this F is parsed as an unknown unit.

[codspeed-hq]

CodSpeed Performance Report

Merging #2535 will improve performances by 34.29%

_{Comparing neokidev:feat/unit-no-unknown (1f077ac) with main (a094dac)}

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	neokidev:feat/unit-no-unknown	Change
⚡	big5-added.json[cached]	2.9 ms	2.1 ms	+34.29%

[neoki07]

Sorry. I wasn't sure how to add elements to RECOMMENDED_RULES and RECOMMENDED_RULES_AS_FILTERS in crates/biome_configuration/src/linter/rules.rs and edited them directly. I have now realized that the correct approach is to set recommended: true within the declare_rule! macro. I have committed this change accordingly.

[ematipico]

I don't think we need the options for the time being. We can evaluate some options if some users actually need them.

[ematipico]

Can you please document what this hack is for and why it exists?

[neoki07]

I have added a description of the function and the reason for using this function where it's called.

[neoki07]

I don't think we need the options for the time being. We can evaluate some options if some users actually need them.

Understood. I will not add the options for now. (Implementing these options, which in stylelint accept a list of strings or regular expressions can be complex. I feel it would be prudent to carefully decide on the specifications when they are implemented.)

[ematipico]

Thank you!

[togami2864]

Awesome!

[Mouvedia]

ignoreUnits and ignoreFunctions are not implemented

Can you add a table for all the rules that are being implemented?
e.g. support: full / partial / × or green / yellow / red

[neoki07]

Can you add a table for all the rules that are being implemented?

The only options implemented in stylelint are ignoreUnits and ignoreFunctions.

Therefore, the table will look as follows:

Option	Status
ignoreUnits	×
ignoreFunctions	×

[Mouvedia]

@neokidev Sorry I meant a centralised table for all rules so that users can easily tell what's the implementation status of the rules. The details as to why the rules are partially implemented can be added later on.

[ematipico]

@Mouvedia we don't have a place for that, with so much granularity. The best we can provide is:

• current works of the project: ☂️ Biome - current developments #2455
• this umbrella for CSS lint rules: ☂️ stylelint recommended rules #2511