Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update useForOf to include a relevant example #2429

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

DeJayDev
Copy link
Contributor

Summary

Unintuitively, the documents for useForOf do not include an actual forOf. While the actual rule does check for the index accession shown in the documents already, it doesn't respect the typescript-eslint rule.

Test Plan

: )

@github-actions github-actions bot added the A-Website Area: website label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit e2e3ae0
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661a3ce3d876710008420ecb
😎 Deploy Preview https://deploy-preview-2429--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@arendjr
Copy link
Contributor

arendjr commented Apr 13, 2024

Thanks! Can you add this to the Rust source of the rules? The docs are generated from there.

@DeJayDev DeJayDev changed the title Add a forOf to useForOf docs docs: update useForOf to include a relevant example Apr 13, 2024
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 13, 2024
@DeJayDev
Copy link
Contributor Author

DeJayDev commented Apr 13, 2024

Thank you for the heads up! I totally missed that. I've included it in both files because I don't know how often the Markdown files are overwritten with the Rust rule comment (that's at least what I'm assuming what happens off your comment).

I also got the chance to reread the CONTRIBUTING guidelines and realized I hadn't used conventional commits and I felt bad. Hopefully this name and the last commit is better :)

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arendjr arendjr merged commit d4b9452 into biomejs:main Apr 13, 2024
5 checks passed
@Conaclos Conaclos mentioned this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants