fix(lint/a11y/use_button_type): skip the rule with spread attribute

CHANGELOG.md

@@ -33,6 +33,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - Fix [#2211](https://github.com/biomejs/biome/issues/2211). noChildrenProp should work fine when children pass as a prop in a new line. Contributed by @fireairforce
 
+- Fix [#2248](https://github.com/biomejs/biome/issues/2248). `lint/a11y/useButtonType` should not trigger when button element with spread attribute. Contributed by @fireairforce
+
 #### Enhancements
 
 - Add support for object property members in the rule `useSortedClasses`. Contributed by @ematipico

crates/biome_js_analyze/src/lint/a11y/use_button_type.rs

@@ -71,10 +71,18 @@ impl Rule for UseButtonType {
                 }
                 let type_attribute = element.find_attribute_by_name("type").ok()?;
                 let Some(attribute) = type_attribute else {
-                    return Some(UseButtonTypeState {
-                        range: element.range(),
-                        missing_prop: true,
-                    });
+                    let has_spread_prop = element
+                        .attributes()
+                        .into_iter()
+                        .any(|attr| attr.as_jsx_spread_attribute().is_some());
+                    if has_spread_prop {
+                        return None;
+                    } else {
+                        return Some(UseButtonTypeState {
+                            range: element.range(),
+                            missing_prop: true,
+                        });
+                    }
                 };
                 inspect_jsx_type_attribute(&attribute)
             }
@@ -85,10 +93,18 @@ impl Rule for UseButtonType {
                 }
                 let type_attribute = element.find_attribute_by_name("type").ok()?;
                 let Some(attribute) = type_attribute else {
-                    return Some(UseButtonTypeState {
-                        range: element.range(),
-                        missing_prop: true,
-                    });
+                    let has_spread_prop = element
+                        .attributes()
+                        .into_iter()
+                        .any(|attr| attr.as_jsx_spread_attribute().is_some());
+                    if has_spread_prop {
+                        return None;
+                    } else {
+                        return Some(UseButtonTypeState {
+                            range: element.range(),
+                            missing_prop: true,
+                        });
+                    }
                 };
                 inspect_jsx_type_attribute(&attribute)
             }

crates/biome_js_analyze/tests/specs/a11y/useButtonType/inJsx.jsx

@@ -17,4 +17,5 @@
     <button type={dynamic_value}>do something</button>
     <button type="button"/>
     <button type={dynamic_value}/>
+    <button {...props}></button>
 </>

crates/biome_js_analyze/tests/specs/a11y/useButtonType/inJsx.jsx.snap

@@ -23,6 +23,7 @@ expression: inJsx.jsx
     <button type={dynamic_value}>do something</button>
     <button type="button"/>
     <button type={dynamic_value}/>
+    <button {...props}></button>
 </>
 ```
 
@@ -178,5 +179,3 @@ inJsx.jsx:10:5 lint/a11y/useButtonType ━━━━━━━━━━━━━
 
 
 ```
-
-

website/src/content/docs/internals/changelog.md

@@ -39,6 +39,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - Fix [#2211](https://github.com/biomejs/biome/issues/2211). noChildrenProp should work fine when children pass as a prop in a new line. Contributed by @fireairforce
 
+- Fix [#2248](https://github.com/biomejs/biome/issues/2248). `lint/a11y/useButtonType` should not trigger when button element with spread attribute. Contributed by @fireairforce
+
 #### Enhancements
 
 - Add support for object property members in the rule `useSortedClasses`. Contributed by @ematipico