-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vscode): switch from npm
to pnpm
#219
Conversation
Does vsce support pnpm now? The main reason we stayed at npm was because pnpm wasn't supported |
Since we bundle the extension, it does not matter. The reason |
@nhedger we need to update the workflows with pnpm The release workflow is failing https://github.com/biomejs/biome/actions/runs/6153342088/job/16697066155#step:13:1 |
I can take a stab at it later today. |
|
@nhedger not sure if this was explained in the vsce repository discussion, but thanks! |
Summary
This PR:
npm
withpnpm
for managing the dependencies of the VS Code extension.editors/vscode
folder as a pnpm workspaceAdditionally, this PR updates the
package
script so thatvsce
does not attempt to includenode_modules
in the VSIX file. This is required because at the momentvsce
is not able to resolve dependencies downloaded bypnpm
. This should not have any effect because we're already bundling the extension with all of its dependencies (--bundle
is compile script).Test Plan
pnpm build
pnpm package
pnpm pack:dev