Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discrepancies on file source detection #2116

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Sec-ant
Copy link
Member

@Sec-ant Sec-ant commented Mar 17, 2024

Summary

Fix discrepancies on file source detection. Allow module syntax in .cts files.

Fixes #2114.

Test Plan

Added a test case to show that the following statement can be used in a .cts file:

export default { cjs: true };

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Mar 17, 2024
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 921858f
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f6a4c6c6767b00082b7cd2
😎 Deploy Preview https://deploy-preview-2116--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sec-ant Sec-ant force-pushed the fix/file-source-detection branch from e4aa2d5 to 921858f Compare March 17, 2024 08:07
Copy link

codspeed-hq bot commented Mar 17, 2024

CodSpeed Performance Report

Merging #2116 will not alter performance

Comparing Sec-ant:fix/file-source-detection (921858f) with main (984626d)

Summary

✅ 93 untouched benchmarks

Copy link
Contributor

@togami2864 togami2864 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@togami2864 togami2864 merged commit 5f60beb into biomejs:main Mar 18, 2024
19 checks passed
@Sec-ant Sec-ant deleted the fix/file-source-detection branch March 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Typescripts "Module" syntax is invalid for typescript-enabled common js
3 participants