feat(biome_css_analyzer): initilize css linter infra #2111
Conversation
github-actions
bot
added
A-Project
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| /// } | ||
| /// ``` | ||
| /// | ||
| pub ColorNoInvalidHex { |
There was a problem hiding this comment.
I've adjusted Stylelint anyway. Should we consider enforcing naming conventions similar to js linters?
https://github.com/biomejs/biome/blob/main/crates/biome_analyze/CONTRIBUTING.md#choose-a-name
There was a problem hiding this comment.
At the beginning the convention made sense because we had few query types, but now I don't think it makes sense anymore. I think we should just kill the convention and put all the rules in the same folder. What do you think?
There was a problem hiding this comment.
I totally agree that idea since that convention confuses some contributors sometimes. I often see that the rule uses Ast is putted in the /semantic_analyzer...
There was a problem hiding this comment.
@ematipico What about lint rule name convention? Should we adhere to the rule names in Stylelint?
There was a problem hiding this comment.
Rule names should adhere to our convention :)
CodSpeed Performance ReportMerging #2111 will not alter performanceComparing Summary
|
togami2864
force-pushed
the
feat/css-linter-infra
branch
from
fb3a82e
to
d854daa
Compare
There was a problem hiding this comment.
Thank you for taking the lead! That's an amazing step forward :)
Whenever you can, can you update this table and put the ⌛ emoji for the CSS linting?
I am going to merge this PR so you can continue your works
Summary
I've experimentally created a new task called
just new-css-lintruleand initialized theColorNoInvalidHexNoColorInvalidHexCSS linter rule as an example. I'll work on the lintdoc, the website, and rustdoc in another PR later.Since this is an experiment, feel free to comment on anything about the direction, even if it's not directly related to the code:)
Test Plan
Run the new task on my local machine and check the files.