Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run biome on more than a few directories #2099

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

SuperchupuDev
Copy link
Member

Summary

  • For some reason the root package.json scripts only ran Biome on a handful of directories. Changed it to run on every directory except a few ones
  • Made CI run the ci script instead of check
  • Changed all Rome mentions to Biome in the benchmark script
  • Changed CI to explicitly use the run pnpm command, for slightly faster execution time. The alias pnpm <script> is meant as a developer shortcut

Test Plan

CI should pass

@github-actions github-actions bot added the A-Website Area: website label Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 3c500af
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f385fd19b03f000839555a
😎 Deploy Preview https://deploy-preview-2099--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner March 14, 2024 22:53
@SuperchupuDev SuperchupuDev removed the request for review from a team March 14, 2024 23:04
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great clean-up!

benchmark/bench.biome.json Show resolved Hide resolved
@SuperchupuDev SuperchupuDev merged commit 745afc8 into main Mar 14, 2024
11 checks passed
@SuperchupuDev SuperchupuDev deleted the superchupu/chore/run-format-on-root branch March 14, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants