Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve pnpm usage #2069

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Conversation

SuperchupuDev
Copy link
Member

@SuperchupuDev SuperchupuDev commented Mar 12, 2024

Summary

  • Removes pnpm lockfiles from some package directories. In pnpm monorepos there should only be the root one
  • Bumps all js dependencies (including major updates, hopefully nothing breaks)
  • Sorts .gitattributes
  • Adds shared to pnpm-workspace.yaml
  • Adds the packageManager field for corepack users. For more info see https://nodejs.org/api/corepack.html. It makes the pnpm workflow use that field. Also removes engines.pnpm
  • Minor package.json improvements

For maintainers:

  • Consider using pnpm via corepack, that way every single maintainer can stay in sync with the same pnpm version specified in the packageManager field
  • Bumping deps should be done at the root directory with the -r (recursive) flag to avoid future monorepo problems

Test Plan

CI should pass

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner March 12, 2024 21:00
@github-actions github-actions bot added A-Formatter Area: formatter A-Website Area: website labels Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 37a9ad6
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f30fa464dc2d0008f3fb2e
😎 Deploy Preview https://deploy-preview-2069--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SuperchupuDev SuperchupuDev requested review from a team and removed request for a team March 12, 2024 21:02
@Conaclos
Copy link
Member

Do you think it could be worth adding some instructions in our CONTRIBUTING guide?

@SuperchupuDev
Copy link
Member Author

Sounds good, will do

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.gitattributes Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@SuperchupuDev
Copy link
Member Author

i think my last commit fixes netlify not using cache
image

previous discussion:
image

@SuperchupuDev
Copy link
Member Author

ci is throwing errors about no space left on device on the rust setup actions. my last few commits don't add anything that could cause that problem

@ematipico
Copy link
Member

ci is throwing errors about no space left on device on the rust setup actions. my last few commits don't add anything that could cause that problem

Yeah it's unrelated to your changes, feel free to merge your PR

@SuperchupuDev SuperchupuDev merged commit 8dac854 into main Mar 14, 2024
17 of 19 checks passed
@SuperchupuDev SuperchupuDev deleted the superchupu/chore/improve-pnpm-usage branch March 14, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants