Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind config analyzer package (initial version) #1884

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

DaniGuardiola
Copy link
Contributor

@DaniGuardiola DaniGuardiola commented Feb 22, 2024

Summary

A package to cover our needs for introspecting Tailwind CSS configs to generate presets (and, in the future, user-provided configs) for utility class sorting. For now, it codegens the utilities preset. You can try this by running pnpm gen:tailwind-preset from packages/@biomejs/tailwindcss-config-analyzer.

Test Plan

For now, there's no need for automated tests. Manual inspection of the output looks correct.

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit b472b9f
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65e09f97e08b5e0008f93156
😎 Deploy Preview https://deploy-preview-1884--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@DaniGuardiola DaniGuardiola marked this pull request as draft February 22, 2024 01:58
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Feb 22, 2024
@DaniGuardiola DaniGuardiola self-assigned this Feb 22, 2024
@DaniGuardiola DaniGuardiola marked this pull request as ready for review February 22, 2024 03:08
@DaniGuardiola DaniGuardiola requested review from a team February 22, 2024 03:08
Copy link

codspeed-hq bot commented Feb 22, 2024

CodSpeed Performance Report

Merging #1884 will not alter performance

⚠️ No base runs were found

Falling back to comparing feat/tailwind-config-analyzer-package (b472b9f) with main (78dc430)

Summary

✅ 93 untouched benchmarks

@DaniGuardiola
Copy link
Contributor Author

Note for myself: need to figure out why the class order is different in the tests.

@ematipico
Copy link
Member

@DaniGuardiola maybe for now we can add the package without updating the Rust file, so we can figure out later what's going on in a different PR, how does that sound?

@DaniGuardiola DaniGuardiola dismissed anonrig’s stale review February 29, 2024 15:14

addressed comments

@DaniGuardiola
Copy link
Contributor Author

@ematipico ended up just fixing it, it was a minor issue

@DaniGuardiola DaniGuardiola added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit b0742b5 Feb 29, 2024
19 checks passed
@DaniGuardiola DaniGuardiola deleted the feat/tailwind-config-analyzer-package branch February 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants