Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useNamingConvention): accept unicase characters #1806

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Feb 13, 2024

Summary

Close #1786

unicase letters have a single case: they are neither uppercase nor lowercase.
Previously, Biome reported names in unicase as invalid.
It now accepts a name in unicase everywhere.

The following code is now accepted:

const 안녕하세요 = { 안녕하세요: 0 };

We still reject a name that mixes unicase characters with lowercase and uppercase characters:
The following names are rejected:

const A안녕하세요 = { a안녕하세요: 0 };

I also removed some dead code in Case::convert and improved the documentation of Case::is_compatible.

Test Plan

  • New tests added.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit e4296bd
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65cb5d334d98b500089a0746
😎 Deploy Preview https://deploy-preview-1806--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Feb 13, 2024
@Conaclos Conaclos force-pushed the conaclos/lint/useNamingConvention/1786 branch from d1f80bd to e4296bd Compare February 13, 2024 12:14
@Conaclos Conaclos requested review from a team February 13, 2024 12:15
Copy link

codspeed-hq bot commented Feb 13, 2024

CodSpeed Performance Report

Merging #1806 will degrade performances by 7.82%

Comparing conaclos/lint/useNamingConvention/1786 (e4296bd) with main (dca6a7a)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/lint/useNamingConvention/1786 Change
eucjp.json[uncached] 5 ms 5.5 ms -7.82%

@Conaclos Conaclos merged commit 700efad into main Feb 13, 2024
21 of 22 checks passed
@Conaclos Conaclos deleted the conaclos/lint/useNamingConvention/1786 branch February 13, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useNamingConvention can suggest useless fix
1 participant