Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noNonNullAssertion): dont create an incorrect unsafe fix for x[y.z!] #1757

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Feb 6, 2024

Summary

Closes #1748

Now we won't create an unsafe fix for the NoNonNullAssertion rule for the following case

x[y.z!]

Test Plan

Add a new test case

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit ed18e85
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65c1d1dc400e1f0008c2ff8b
😎 Deploy Preview https://deploy-preview-1757--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Feb 6, 2024
Copy link

codspeed-hq bot commented Feb 6, 2024

CodSpeed Performance Report

Merging #1757 will degrade performances by 6.45%

⚠️ No base runs were found

Falling back to comparing ah-yu:non_null_assertion_action (ed18e85) with main (1646ddb)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ah-yu:non_null_assertion_action Change
router.ts[uncached] 12.5 ms 13.4 ms -6.45%

Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Conaclos Conaclos merged commit 9047bba into biomejs:main Feb 6, 2024
18 of 19 checks passed
@ah-yu ah-yu deleted the non_null_assertion_action branch February 7, 2024 02:36
@ah-yu ah-yu mentioned this pull request Feb 15, 2024
1 task
Copy link

@ifteneiftene ifteneiftene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok bien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(unsafe) 🐛 Forbidden non-null assertion lint/style/noNonNullAssertion creates a bad fix
3 participants