Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useOptionalChain): unsafe fix incorrectly discards conditions in logical and chains #1685

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

lucasweng
Copy link
Contributor

Summary

Test Plan

Added a new test case and other existing tests should pass.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 26d6e52
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65b3dd1e9b97290008c4066b
😎 Deploy Preview https://deploy-preview-1685--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jan 26, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats' great! It seems there are conflicts. We can merge the PR once they are resolved

Copy link

codspeed-hq bot commented Jan 26, 2024

CodSpeed Performance Report

Merging #1685 will not alter performance

⚠️ No base runs were found

Falling back to comparing lucasweng:lint/1656 (26d6e52) with main (c2dd5f0)

Summary

✅ 93 untouched benchmarks

@ematipico ematipico merged commit 82917c7 into biomejs:main Jan 26, 2024
19 checks passed
@lucasweng lucasweng deleted the lint/1656 branch January 27, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useOptionalChain unsafe fix incorrectly discards conditions in logical and chains
2 participants