fix: noInvalidUseBeforeDeclaration false-positive for param destructuring with default values

CHANGELOG.md

@@ -70,6 +70,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 #### Bug fixes
 
+- Fix [#1648](https://github.com/biomejs/biome/issues/1648). [noInvalidUseBeforeDeclaration](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration/) now ignores when identifier destructured in function params. Contributed by @vasucp1207
+
 - Fix [#1640](https://github.com/biomejs/biome/issues/1640). [useEnumInitializers](https://biomejs.dev/linter/rules/use-enum-initializers) code action now generates valid code when last member has a comment but no comma. Contributed by @kalleep
 
 ### Parser

crates/biome_js_analyze/src/lib.rs

@@ -259,7 +259,6 @@ mod tests {
             dependencies_index: Some(1),
         };
         let rule_filter = RuleFilter::Rule("nursery", "noDisabledTests");
-
         options.configuration.rules.push_rule(
             RuleKey::new("nursery", "useHookAtTopLevel"),
             RuleOptions::new(HooksOptions { hooks: vec![hook] }),

crates/biome_js_analyze/src/semantic_analyzers/nursery/no_invalid_use_before_declaration.rs

@@ -3,7 +3,7 @@ use biome_analyze::{context::RuleContext, declare_rule, Rule, RuleDiagnostic, Ru
 use biome_console::markup;
 use biome_js_syntax::{
     binding_ext::{AnyJsBindingDeclaration, AnyJsIdentifierBinding},
-    AnyJsExportNamedSpecifier, AnyJsIdentifierUsage,
+    AnyJsExportNamedSpecifier, AnyJsIdentifierUsage, JsObjectBindingPatternShorthandProperty,
 };
 use biome_rowan::{AstNode, SyntaxNodeOptionExt, TextRange};
 
@@ -136,6 +136,20 @@ impl Rule for NoInvalidUseBeforeDeclaration {
                     // type Y = typeof X;
                     // const X = 0;
                     // ```
+                    && reference
+                        .syntax()
+                        .ancestors()
+                        .nth(3)
+                        .filter(|ancestor| JsObjectBindingPatternShorthandProperty::can_cast(ancestor.kind()))
+                        .is_none()
+                    // ignore when identifier destructured in function params
+                    // For example:
+                    //
+                    // ```js
+                    // const aFunction = ({a = '111', b = a}) => {
+                    //  console.info(a,b);
+                    // }
+                    // ```
                     && !AnyJsIdentifierUsage::cast_ref(reference.syntax())
                         .is_some_and(|usage| usage.is_only_type())
                 {

crates/biome_js_analyze/tests/specs/nursery/noInvalidUseBeforeDeclaration/valid.js

@@ -10,3 +10,19 @@ export { X }; const X = 1;
 let a; console.log(a);
 
 function h() { Y; }; const Y = 0;
+
+const aFunction = (a = '111', b = a) => {
+    console.info(a,b);
+}
+
+const aFunction = (b = a) => {
+    console.info(a,b);
+}
+
+const aFunction = ({a = '111', b = a}) => {
+    console.info(a,b);
+}
+
+const aFunction = ({b = a}) => {
+    console.info(a,b);
+}

crates/biome_js_analyze/tests/specs/nursery/noInvalidUseBeforeDeclaration/valid.js.snap

@@ -17,6 +17,22 @@ let a; console.log(a);
 
 function h() { Y; }; const Y = 0;
 
+const aFunction = (a = '111', b = a) => {
+    console.info(a,b);
+}
+
+const aFunction = (b = a) => {
+    console.info(a,b);
+}
+
+const aFunction = ({a = '111', b = a}) => {
+    console.info(a,b);
+}
+
+const aFunction = ({b = a}) => {
+    console.info(a,b);
+}
+
 ```
 
 

website/src/content/docs/internals/changelog.mdx

@@ -76,6 +76,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 #### Bug fixes
 
+- Fix [#1648](https://github.com/biomejs/biome/issues/1648). [noInvalidUseBeforeDeclaration](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration/) now ignores when identifier destructured in function params. Contributed by @vasucp1207
+
 - Fix [#1640](https://github.com/biomejs/biome/issues/1640). [useEnumInitializers](https://biomejs.dev/linter/rules/use-enum-initializers) code action now generates valid code when last member has a comment but no comma. Contributed by @kalleep
 
 ### Parser