Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noVar ignores TsGlobalDeclaration #1669

Merged
merged 39 commits into from
Jan 26, 2024
Merged

Conversation

vasucp1207
Copy link
Member

Summary

Closes #1651

Test Plan

New test case added,

declare global {
    var Txt: CustomWindow['Txt'];
}

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 26373bc
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65b29ef469663100085f5861

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jan 25, 2024
Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #1669 will improve performances by 13.55%

Comparing vasucp1207:noVarTsGlobal (26373bc) with main (c0ee00b)

Summary

⚡ 8 improvements
✅ 85 untouched benchmarks

Benchmarks breakdown

Benchmark main vasucp1207:noVarTsGlobal Change
analyzer[router.ts] 85.9 ms 75.7 ms +13.55%
analyzer[index.js] 201.8 ms 181.9 ms +10.94%
analyzer[parser.ts] 297.4 ms 263.5 ms +12.84%
analyzer[css.js] 84.4 ms 77.1 ms +9.52%
analyzer[statement.ts] 266.6 ms 235.6 ms +13.18%
analyzer[lint.ts] 156.7 ms 140.8 ms +11.31%
analyzer[typescript.ts] 425.2 ms 379.4 ms +12.05%
db.json[cached] 77.5 ms 71.4 ms +8.45%

@Conaclos Conaclos merged commit c2dd5f0 into biomejs:main Jan 26, 2024
19 checks passed
@Conaclos
Copy link
Member

@vasucp1207 feel free to merge once approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 lint/style/noVar triggered in a declare statement
2 participants