Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: biome-ignore as suppression comment #163

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ematipico
Copy link
Member

Summary

Closes #55
Closes #156

I decided not to emit a code action for updating the comment for now.

Test Plan

I updated all the tests that involve suppression comments. I updated tests to track the new suppression diagnostic.

@ematipico ematipico temporarily deployed to Website deployment September 5, 2023 16:56 — with GitHub Actions Inactive
@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter A-Parser Area: parser A-LSP Area: language server protocol A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47808 47808 0
Failed 1055 1055 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1764 1764 0
Failed 4448 4448 0
Panics 0 0 0
Coverage 28.40% 28.40% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13121 13121 0
Failed 4103 4103 0
Panics 0 0 0
Coverage 76.18% 76.18% 0.00%

@ematipico ematipico force-pushed the feat/biome-ignore-suppression branch from 66733f5 to 9753f3a Compare September 5, 2023 17:09
@ematipico ematipico temporarily deployed to Website deployment September 5, 2023 17:09 — with GitHub Actions Inactive
@ematipico ematipico merged commit 3c170f2 into main Sep 6, 2023
@ematipico ematipico deleted the feat/biome-ignore-suppression branch September 6, 2023 06:20
Conaclos pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create fixable diagnostic to emit when // rome-ignore is encountered 📎 Support biome-ignore comment
1 participant