Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): correctly handle multibyte chars in regexes #1592

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #1522

Multibyte characters are now handled correctly by noMisleadingCharacterClass, noMultipleSpacesInRegularExpressionLiterals, and noEmptyCharacterClassInRegex.

noControlCharactersInRegex was not affected by the bug.

Test Plan

  • New tests added.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 0be7d65
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a94b261c03cf00082b3e00
😎 Deploy Preview https://deploy-preview-1592--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jan 18, 2024
@Conaclos Conaclos merged commit d6b263a into main Jan 18, 2024
20 of 21 checks passed
@Conaclos Conaclos deleted the conaclos/lint/1522 branch January 18, 2024 16:16
Copy link

codspeed-hq bot commented Jan 18, 2024

CodSpeed Performance Report

Merging #1592 will not alter performance

⚠️ No base runs were found

Falling back to comparing conaclos/lint/1522 (0be7d65) with main (935bf9d)

Summary

✅ 93 untouched benchmarks

ematipico pushed a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 Linter fail on code files contains literal RegExp contains Cyrillic symbols
1 participant