Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): add third-party tool in continuous integration section #1585

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

mongolyy
Copy link
Contributor

@mongolyy mongolyy commented Jan 17, 2024

Summary

I have created github actions that work with reviewdog to utilize the pull request commenting and commit suggestion functionality.

https://github.com/marketplace/actions/run-biome-with-reviewdog
https://github.com/mongolyy/reviewdog-action-biome

I believe this action will improve the usability of the combination of biome and github actions.

Test Plan

Check the deployment preview.

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 4113c14
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a7eacdb904590008c7b2ea
😎 Deploy Preview https://deploy-preview-1585--biomejs.netlify.app/recipes/continuous-integration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-Website Area: website label Jan 17, 2024
@mongolyy mongolyy marked this pull request as ready for review January 17, 2024 15:17
@mongolyy
Copy link
Contributor Author

I have created a pull request, but if you would like to create an issue or discussion to discuss it, please let me know.

@ematipico
Copy link
Member

Can you give us more context? What does this action do more than Biome? The ci command already supports annotations on GitHub

@mongolyy
Copy link
Contributor Author

Thanks for the response.

With annotation, the pull request is just commented and we have to open the IDE, github.dev, etc. to fix it.
I thought it would be useful to be able to modify the remarks from Biome with a few clicks on the github pull request screen.

See the sample pull request.
mongolyy/reviewdog-action-biome#27

I made it so that commit suggestions are made based on the results of biome check --apply.
Of course, if something can't be safe fixed, it will be commented in the pull request.

I think this will make it easier for developers to fix things that are pointed out by biome.

Sorry if this is not in line with the intention of the biome development team.
In that case, I will close this pull request.

@ematipico
Copy link
Member

That's actually pretty neat! Amazing tool indeed! I'm happy to integrate it in our docs

@ematipico ematipico merged commit 19cba71 into biomejs:main Jan 24, 2024
7 checks passed
@mongolyy mongolyy deleted the patch-1 branch January 25, 2024 13:16
@mongolyy
Copy link
Contributor Author

Thank you. I am glad to hear you say so.
I am also happy to contribute to Biome.

I will continue to support Biome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants