Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js_formatter): fix #1511 #1547

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix(js_formatter): fix #1511 #1547

merged 2 commits into from
Jan 12, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #1511

Test Plan

New test added.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 6d5bebb
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a1adc75e1c4b0008c7063c
😎 Deploy Preview https://deploy-preview-1547--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Formatter Area: formatter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jan 12, 2024
@Conaclos Conaclos force-pushed the conaclos/formatter/1511 branch from ac04415 to 92ad11c Compare January 12, 2024 20:42
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Jan 12, 2024

CodSpeed Performance Report

Merging #1547 will improve performances by 7.33%

Comparing conaclos/formatter/1511 (6d5bebb) with main (3bd7a9c)

Summary

⚡ 1 improvements
✅ 89 untouched benchmarks

🆕 3 new benchmarks

Benchmarks breakdown

Benchmark main conaclos/formatter/1511 Change
big5-added.json[cached] 2.4 ms 2.3 ms +7.33%
🆕 typescript.js[cached] N/A 5 s N/A
🆕 json_formatter[typescript.js] N/A 18.4 s N/A
🆕 typescript.js[uncached] N/A 5.5 s N/A

@Conaclos Conaclos force-pushed the conaclos/formatter/1511 branch from 9eaa77a to 6d5bebb Compare January 12, 2024 21:23
@Conaclos Conaclos merged commit cf3434c into main Jan 12, 2024
22 checks passed
@Conaclos Conaclos deleted the conaclos/formatter/1511 branch January 12, 2024 22:29
ematipico added a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Invalid document: Expected end tag of kind Indent but found Group.
2 participants