Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css-parser): CSS Parser: parse document at rule #1303 #1535

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

denbezrukov
Copy link
Contributor

Summary

Close #1303

https://www.w3.org/TR/2012/WD-css3-conditional-20120911/#at-document

@document [ <url>                   |
            url-prefix(<string>)     |
            domain(<string>)         |
            media-document(<string>) |
            regexp(<string>)
          ]# {
  <group-rule-body>
 }

Test Plan

cargo test

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit a3fe5e9
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a072447a337c0008046b89

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels Jan 11, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

Copy link

codspeed-hq bot commented Jan 11, 2024

CodSpeed Performance Report

Merging #1535 will degrade performances by 7.45%

Comparing feat/css-document-at-rule (a3fe5e9) with main (7f78594)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/css-document-at-rule Change
eucjp.json[uncached] 5.1 ms 5.5 ms -7.45%

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Great documentation and code :D

@denbezrukov denbezrukov merged commit e7fe085 into main Jan 12, 2024
20 of 21 checks passed
@denbezrukov denbezrukov deleted the feat/css-document-at-rule branch January 12, 2024 10:20
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Parser: parse document at rule
3 participants