Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): add source metadata #1519

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jan 10, 2024

Summary

Fix #1200

  • Rename Source to RuleSource
  • Rename SourceKind to RuleSourceKind
  • Add missing rule sources
  • Use RuleSourceKind::SameLogic as default value
    Most of the rules use the same logic, this looks like a good default.
  • Add source metadata for all rules

Test Plan

I checked that this appears correctly on the rule pages.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 208dceb
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65a06019e9bcf70008cffab1
😎 Deploy Preview https://deploy-preview-1519--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Tooling Area: internal tools A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Jan 10, 2024
@Conaclos Conaclos changed the title Conaclos/linter/rule source refactor(linter): add source metadata Jan 10, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

Copy link

codspeed-hq bot commented Jan 10, 2024

CodSpeed Performance Report

Merging #1519 will improve performances by 13.75%

⚠️ No base runs were found

Falling back to comparing conaclos/linter/rule-source (208dceb) with main (2cd6eaf)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/linter/rule-source Change
big5-added.json[uncached] 3.2 ms 2.9 ms +13.75%

@Conaclos Conaclos force-pushed the conaclos/linter/rule-source branch from 21c7273 to 970936e Compare January 11, 2024 21:00
@github-actions github-actions bot added the A-Project Area: project label Jan 11, 2024
@Conaclos Conaclos force-pushed the conaclos/linter/rule-source branch from 970936e to 208dceb Compare January 11, 2024 21:39
@Conaclos Conaclos merged commit 7f78594 into main Jan 11, 2024
18 of 19 checks passed
@Conaclos Conaclos deleted the conaclos/linter/rule-source branch January 11, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Project Area: project A-Tooling Area: internal tools A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Add source and source_kind to a rule metadata
2 participants