fix(cli): correctly compute ignored files #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
ematipico
commented
Sep 4, 2023
| @@ -214,7 +214,8 @@ const SELF_FILTER: LevelFilter = if cfg!(debug_assertions) { | |||
|
|
|||
| impl LoggingFilter { | |||
| fn is_enabled(&self, meta: &Metadata<'_>) -> bool { | |||
| let filter = if meta.target().starts_with("biome") { | |||
| // TODO: keep "rome" until all internal crates are moved to "biome_" | |||
| let filter = if meta.target().starts_with("rome") { | |||
There was a problem hiding this comment.
This prevented from logging correctly
ematipico
force-pushed
the
fix/ignored-files
branch
from
c0e75d3 to
09b564e
Compare
Conaclos
approved these changes
Sep 4, 2023
ematipico
force-pushed
the
fix/ignored-files
branch
from
09b564e to
e5f9cd7
Compare
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
force-pushed
the
fix/ignored-files
branch
from
567ca73 to
da39918
Compare
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
force-pushed
the
fix/ignored-files
branch
from
da39918 to
d81940d
Compare
ematipico
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #139
Test Plan
Added a new test case for the
checkcommand