Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useConsistentArrayType): correctly handle rule's option #1490

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jan 9, 2024

Summary

Fix #1483

Test Plan

New tests added.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 44e828e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659d320ed46ba7000839baf7
😎 Deploy Preview https://deploy-preview-1490--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jan 9, 2024
Copy link

codspeed-hq bot commented Jan 9, 2024

CodSpeed Performance Report

Merging #1490 will improve performances by 6.46%

⚠️ No base runs were found

Falling back to comparing conaclos/lint/useConsistentArrayType (44e828e) with main (2ad817a)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/lint/useConsistentArrayType Change
router.ts[cached] 11.5 ms 10.8 ms +6.46%

@Conaclos Conaclos merged commit d0d7aec into main Jan 9, 2024
22 checks passed
@Conaclos Conaclos deleted the conaclos/lint/useConsistentArrayType branch January 9, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 useConsistentArrayType won't accept options
1 participant