Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the correct diagnostic level in advice #1475

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: Use the correct diagnostic level in advice #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ome_cli/tests/snapshots/main_cases_protected_files/not_process_file_from_cli_verbose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ package.json project ━━━━━━━━━━━━━━━━━━━

Verbose advice

i You can hide this diagnostic by using --diagnostic-level=warning to increase the diagnostic level shown by CLI.
i You can hide this diagnostic by using --diagnostic-level=warn to increase the diagnostic level shown by CLI.


```
Expand Down
2 changes: 1 addition & 1 deletion ...ests/snapshots/main_cases_protected_files/not_process_file_from_stdin_verbose_format.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package.json project ━━━━━━━━━━━━━━━━━━━

Verbose advice

i You can hide this diagnostic by using --diagnostic-level=warning to increase the diagnostic level shown by CLI.
i You can hide this diagnostic by using --diagnostic-level=warn to increase the diagnostic level shown by CLI.


```
Expand Down
2 changes: 1 addition & 1 deletion .../tests/snapshots/main_cases_protected_files/not_process_file_from_stdin_verbose_lint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package.json project ━━━━━━━━━━━━━━━━━━━

Verbose advice

i You can hide this diagnostic by using --diagnostic-level=warning to increase the diagnostic level shown by CLI.
i You can hide this diagnostic by using --diagnostic-level=warn to increase the diagnostic level shown by CLI.


```
Expand Down
2 changes: 1 addition & 1 deletion crates/biome_service/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ pub struct ProtectedFileAdvice;

impl Advices for ProtectedFileAdvice {
fn record(&self, visitor: &mut dyn Visit) -> std::io::Result<()> {
visitor.record_log(LogCategory::Info, &markup! { "You can hide this diagnostic by using "<Emphasis>"--diagnostic-level=warning"</Emphasis>" to increase the diagnostic level shown by CLI." })
visitor.record_log(LogCategory::Info, &markup! { "You can hide this diagnostic by using "<Emphasis>"--diagnostic-level=warn"</Emphasis>" to increase the diagnostic level shown by CLI." })
}
}

Expand Down