refactor(lint/noEmptyInterface): ignore empty interface that extends a type #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Project
ematipico
approved these changes
Dec 22, 2023
crates/biome_js_analyze/src/analyzers/suspicious/no_empty_interface.rs
Outdated
Show resolved
Hide resolved
Conaclos
force-pushed
the
conaclos/lint/noEMptyInterfaceExtends
branch
from
325a686 to
b68c7e6
Compare
Conaclos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #1157
I was on the fence on this and I agree with the last comment left in the issue. We should not report empty interfaces that extend a type. Let's diverge from ESLint.
Test Plan
Updated tests.