Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noRedeclare): allow overloads #1062

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Dec 5, 2023

Summary

Fix #1061

Test Plan

Anti-regression tests added.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit d6aaf79
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/656f43c279d47900088f13b7
😎 Deploy Preview https://deploy-preview-1062--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

@Conaclos Conaclos merged commit 3f0abb9 into main Dec 5, 2023
20 checks passed
@Conaclos Conaclos deleted the conaclos/lint/noRedeclare/1061 branch December 5, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Parser Area: parser A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 False positive on lint/suspicious/noRedeclare when default-exporting overloaded functions
1 participant