-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use rustc-hash #538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
temporarily deployed
to
Website deployment
October 17, 2023 13:33 — with
GitHub Actions
Inactive
github-actions
bot
added
A-CLI
Area: CLI
A-Core
Area: core
A-Project
Area: project
A-Linter
Area: linter
A-Parser
Area: parser
A-Formatter
Area: formatter
A-LSP
Area: language server protocol
L-JavaScript
Language: JavaScript and super languages
L-JSON
Language: JSON and super languages
labels
Oct 17, 2023
!bench_analyzer |
!bench_formatter |
!bench_cli |
!bench_parser |
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Analyzer Benchmark Results
|
ematipico
approved these changes
Oct 17, 2023
Formatter Benchmark Results
|
Parser Benchmark Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Changelog
Area: changelog
A-CLI
Area: CLI
A-Core
Area: core
A-Formatter
Area: formatter
A-Linter
Area: linter
A-LSP
Area: language server protocol
A-Parser
Area: parser
A-Project
Area: project
L-JavaScript
Language: JavaScript and super languages
L-JSON
Language: JSON and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
FxHashSet
andFxHasMap
where possible.This is a basic tip to ensure efficient computation of hashes.
Test Plan
Ci should pass. No perf regression should be noticed on benchmarks.