Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lint/noUselessLoneBlockStatements): add fix kind metadata #531

Merged
merged 1 commit into from
Oct 16, 2023
Merged

refactor(lint/noUselessLoneBlockStatements): add fix kind metadata #531

merged 1 commit into from
Oct 16, 2023

Conversation

Conaclos
Copy link
Member

Summary

Add missing fix kind metadata.

Test Plan

CI.

@Conaclos Conaclos temporarily deployed to Website deployment October 16, 2023 10:19 — with GitHub Actions Inactive
@github-actions github-actions bot added A-Linter Area: linter A-Tooling Area: internal tools A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Oct 16, 2023
@Conaclos Conaclos force-pushed the conaclos/lint/noUselessLoneBlockStatements/fix-kind-metadata branch from eb35ec6 to 9e64d6e Compare October 16, 2023 10:19
@Conaclos Conaclos temporarily deployed to Website deployment October 16, 2023 10:20 — with GitHub Actions Inactive
ematipico
ematipico reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the changes related to the git submodules?

@vasucp1207
Copy link
Member

Also misses in, NoPositiveTabindex, NoAriaUnsupportedElements, UseAnchorContent, UseValidAriaProps.

@ematipico
Copy link
Member

This is covered in #532

I added strictly checks in that PR

@Conaclos Conaclos force-pushed the conaclos/lint/noUselessLoneBlockStatements/fix-kind-metadata branch from 9e64d6e to 491799e Compare October 16, 2023 12:06
@Conaclos Conaclos temporarily deployed to Website deployment October 16, 2023 12:06 — with GitHub Actions Inactive
@Conaclos Conaclos force-pushed the conaclos/lint/noUselessLoneBlockStatements/fix-kind-metadata branch from 491799e to e5d8f7a Compare October 16, 2023 12:07
@github-actions github-actions bot removed the A-Tooling Area: internal tools label Oct 16, 2023
@Conaclos Conaclos temporarily deployed to Website deployment October 16, 2023 12:07 — with GitHub Actions Inactive
@Conaclos Conaclos merged commit aab7651 into main Oct 16, 2023
17 checks passed
@Conaclos Conaclos deleted the conaclos/lint/noUselessLoneBlockStatements/fix-kind-metadata branch October 16, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

Assignees
No one assigned
Labels
A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Conaclos @vasucp1207 @ematipico