🐛 Comments are removed when updating from rome-ignore to biome-ignore

[stutrek]

Environment information

This is far too long for me to review, and I do see things I shouldn't put in. I can provide a subset of information if needed.

I did get this error when running --apply-unsafe

Biome encountered an unexpected error

This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fixing the issue:

Source Location: /Users/runner/work/biome/biome/crates/rome_rowan/src/ast/mod.rs:230:13
Thread Name: rome::worker_4
Message: Tried to cast node with kind JS_STATIC_MEMBER_EXPRESSION as `"rome_js_syntax::generated::nodes::AnyJsAssignmentPattern"` but was unable to cast

What happened?

Comments before // rome-ignore statements are removed.

Expected result

It should leave these comments in.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[stutrek]

I just did a find and replace to update rome-ignore, but I still get logs about the error above. It does fix things.

[ematipico]

Could please share the code that generates that error please? We're trying to hunt down the rule/code that triggers that for days!

Also:

• I believe we removed the code action of the diagnostic that warns about the deprecated comment in one of the latest patches
• the error you see was generated by some rule that emitted invalid code

[stutrek]

I believe it's this code in combination with complexity/useLiteralKeys

// Add optimizely service to global window; this allows us to debug feature flag flakiness in localhost a bit better
if (typeof window !== 'undefined' && Boolean(window)) {
  ((window as unknown) as Record<string, unknown>)['optimizelyService'] = optimizelyService;
}

const IS_RUNNING_IN_CYPRESS =
  typeof window === 'undefined' ? false : Boolean((window as never)?.['Cypress']);

but it's unrelated to this specific bug :(

[yckbilly1929]

happens on 1.2.2

[ematipico]

I am going to close this.

• the issue described here was closed in fix(lint/useLiteralKeys): emit correct AST for assignment expressions #269
• the code action rome-ignore to biome-ignore was removed in 1.1.1

@yckbilly1929 subscribe to #98, which is a broader issue that doesn't involve a specific rule, but a how code actions are applied to the code, which causes these issues.