fix(cli): rage command should not print any logs around servers (#560)

biomejs · Oct 20, 2023 · 9639141 · 9639141
1 parent 719c745
commit 9639141
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 ### CLI
 
+#### Bug fixes
+
+- Fix `rage` command, now it doesn't print info about running servers. Contributed by @ematipico
+
 ### Configuration
 
 ### Editors

diff --git a/crates/biome_cli/src/commands/rage.rs b/crates/biome_cli/src/commands/rage.rs
@@ -38,20 +38,21 @@ pub(crate) fn rage(session: CliSession, daemon_logs: bool) -> Result<(), CliDiag
     {WorkspaceRage(session.app.workspace.deref())}
     ));
 
-    match session.app.workspace.server_info() {
-        Some(_) if daemon_logs => {
-            session.app.console.log(markup!({
-                ConnectedClientServerLog(session.app.workspace.deref())
-            }));
-        }
-        None => {
-            session
-                .app
-                .console
-                .log(markup!("Discovering running Biome servers..."));
-            session.app.console.log(markup!({ RunningRomeServer }));
+    if daemon_logs {
+        match session.app.workspace.server_info() {
+            Some(_) => {
+                session.app.console.log(markup!({
+                    ConnectedClientServerLog(session.app.workspace.deref())
+                }));
+            }
+            None => {
+                session
+                    .app
+                    .console
+                    .log(markup!("Discovering running Biome servers..."));
+                session.app.console.log(markup!({ RunningRomeServer }));
+            }
         }
-        _ => {}
     }
     Ok(())
 }

diff --git a/website/src/content/docs/internals/changelog.mdx b/website/src/content/docs/internals/changelog.mdx
@@ -20,6 +20,10 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
 ### CLI
 
+#### Bug fixes
+
+- Fix `rage` command, now it doesn't print info about running servers. Contributed by @ematipico
+
 ### Configuration
 
 ### Editors