feat: rename rule

biomejs · Apr 25, 2024 · 7eee138 · 7eee138
1 parent 07408b6
commit 7eee138
Show file tree

Hide file tree

Showing 11 changed files with 58 additions and 47 deletions.
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs
diff --git a/crates/biome_css_analyze/src/lint/nursery.rs b/crates/biome_css_analyze/src/lint/nursery.rs
@@ -7,8 +7,8 @@ pub mod no_css_empty_block;
 pub mod no_duplicate_font_names;
 pub mod no_duplicate_selectors_keyframe_block;
 pub mod no_important_in_keyframe;
-pub mod no_missing_generic_family_keyword;
 pub mod no_unknown_unit;
+pub mod use_generic_font_names;
 
 declare_group! {
     pub Nursery {
@@ -19,8 +19,8 @@ declare_group! {
             self :: no_duplicate_font_names :: NoDuplicateFontNames ,
             self :: no_duplicate_selectors_keyframe_block :: NoDuplicateSelectorsKeyframeBlock ,
             self :: no_important_in_keyframe :: NoImportantInKeyframe ,
-            self :: no_missing_generic_family_keyword :: NoMissingGenericFamilyKeyword ,
             self :: no_unknown_unit :: NoUnknownUnit ,
+            self :: use_generic_font_names :: UseGenericFontNames ,
         ]
      }
 }
diff --git a/...sery/no_missing_generic_family_keyword.rs → ...rc/lint/nursery/use_generic_font_names.rs b/...sery/no_missing_generic_family_keyword.rs → ...rc/lint/nursery/use_generic_font_names.rs
@@ -1,4 +1,4 @@
-use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic};
+use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic, RuleSource};
 use biome_console::markup;
 use biome_css_syntax::{
     AnyCssAtRule, AnyCssGenericComponentValue, AnyCssValue, CssAtRule,
@@ -57,14 +57,15 @@ declare_rule! {
     /// @font-face { font-family: Gentium; }
     /// ```
     ///
-    pub NoMissingGenericFamilyKeyword {
+    pub UseGenericFontNames {
         version: "next",
-        name: "noMissingGenericFamilyKeyword",
-        recommended: false,
+        name: "useGenericFontNames",
+        recommended: true,
+        sources: &[RuleSource::Stylelint("font-family-no-missing-generic-family-keyword")],
     }
 }
 
-impl Rule for NoMissingGenericFamilyKeyword {
+impl Rule for UseGenericFontNames {
     type Query = Ast<CssGenericProperty>;
     type State = TextRange;
     type Signals = Option<Self::State>;

diff --git a/crates/biome_css_analyze/src/options.rs b/crates/biome_css_analyze/src/options.rs
@@ -10,6 +10,7 @@ pub type NoDuplicateFontNames =
     <lint::nursery::no_duplicate_font_names::NoDuplicateFontNames as biome_analyze::Rule>::Options;
 pub type NoDuplicateSelectorsKeyframeBlock = < lint :: nursery :: no_duplicate_selectors_keyframe_block :: NoDuplicateSelectorsKeyframeBlock as biome_analyze :: Rule > :: Options ;
 pub type NoImportantInKeyframe = < lint :: nursery :: no_important_in_keyframe :: NoImportantInKeyframe as biome_analyze :: Rule > :: Options ;
-pub type NoMissingGenericFamilyKeyword = < lint :: nursery :: no_missing_generic_family_keyword :: NoMissingGenericFamilyKeyword as biome_analyze :: Rule > :: Options ;
 pub type NoUnknownUnit =
     <lint::nursery::no_unknown_unit::NoUnknownUnit as biome_analyze::Rule>::Options;
+pub type UseGenericFontNames =
+    <lint::nursery::use_generic_font_names::UseGenericFontNames as biome_analyze::Rule>::Options;
diff --git a/...noMissingGenericFamilyKeyword/invalid.css → ...s/nursery/useGenericFontNames/invalid.css b/...noMissingGenericFamilyKeyword/invalid.css → ...s/nursery/useGenericFontNames/invalid.css
diff --git a/...singGenericFamilyKeyword/invalid.css.snap → ...sery/useGenericFontNames/invalid.css.snap b/...singGenericFamilyKeyword/invalid.css.snap → ...sery/useGenericFontNames/invalid.css.snap
@@ -15,7 +15,7 @@ a { font: 1em Lucida Grande, Arial, "sans-serif" }
 
 # Diagnostics
 ```
-invalid.css:1:18 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:1:18 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   
@@ -37,7 +37,7 @@ invalid.css:1:18 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━
 ```
 
 ```
-invalid.css:2:44 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:2:44 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   
@@ -60,7 +60,7 @@ invalid.css:2:44 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━
 ```
 
 ```
-invalid.css:3:18 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:3:18 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   
@@ -84,7 +84,7 @@ invalid.css:3:18 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━
 ```
 
 ```
-invalid.css:4:18 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:4:18 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   
@@ -108,7 +108,7 @@ invalid.css:4:18 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━
 ```
 
 ```
-invalid.css:5:39 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:5:39 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   
@@ -132,7 +132,7 @@ invalid.css:5:39 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━
 ```
 
 ```
-invalid.css:6:43 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:6:43 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   
@@ -155,7 +155,7 @@ invalid.css:6:43 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━
 ```
 
 ```
-invalid.css:7:37 lint/nursery/noMissingGenericFamilyKeyword ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+invalid.css:7:37 lint/nursery/useGenericFontNames ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   ! Generic font family missing.
   

diff --git a/...y/noMissingGenericFamilyKeyword/valid.css → ...ecs/nursery/useGenericFontNames/valid.css b/...y/noMissingGenericFamilyKeyword/valid.css → ...ecs/nursery/useGenericFontNames/valid.css
diff --git a/...issingGenericFamilyKeyword/valid.css.snap → ...ursery/useGenericFontNames/valid.css.snap b/...issingGenericFamilyKeyword/valid.css.snap → ...ursery/useGenericFontNames/valid.css.snap
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs
@@ -132,6 +132,7 @@ define_categories! {
     "lint/nursery/noUnknownUnit": "https://biomejs.dev/linter/rules/no-unknown-unit",
     "lint/nursery/useBiomeSuppressionComment": "https://biomejs.dev/linter/rules/use-biome-suppression-comment",
     "lint/nursery/useConsistentNewBuiltin": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
+    "lint/nursery/useGenericFontNames": "https://biomejs.dev/linter/rules/use-generic-font-names",
     "lint/nursery/useImportRestrictions": "https://biomejs.dev/linter/rules/use-import-restrictions",
     "lint/nursery/useSortedClasses": "https://biomejs.dev/linter/rules/use-sorted-classes",
     "lint/performance/noAccumulatingSpread": "https://biomejs.dev/linter/rules/no-accumulating-spread",

diff --git a/packages/@biomejs/backend-jsonrpc/src/workspace.ts b/packages/@biomejs/backend-jsonrpc/src/workspace.ts
diff --git a/packages/@biomejs/biome/configuration_schema.json b/packages/@biomejs/biome/configuration_schema.json