fix(noUnusedFunctionParameters): ignore parameter in constructor types (

#4237)

Co-authored-by: zoomdong <[email protected]>

CHANGELOG.md

@@ -103,18 +103,33 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
   Contributed by @Conaclos
 
-- Fixes [#4059](https://github.com/biomejs/biome/issues/4059), the rule [noUselessFragments](https://biomejs.dev/linter/rules/no-useless-fragments/) now correctly handles fragments containing HTML escapes (e.g. ` `) inside expression escapes `{ ... }`.
-The following code is no longer reported:
+- [noUselessFragments](https://biomejs.dev/linter/rules/no-useless-fragments/) now correctly handles fragments containing HTML escapes (e.g. ` `) inside expression escapes `{ ... }` ([#4059](https://github.com/biomejs/biome/issues/4059)).
 
-```jsx
-function Component() {
-  return (
-    <div key={index}>{line || <>&nbsp;</>}</div>
-  )
-}
-```
+  The following code is no longer reported:
+
+  ```jsx
+  function Component() {
+    return (
+      <div key={index}>{line || <>&nbsp;</>}</div>
+    )
+  }
+  ```
 
-Contributed by @fireairforce
+  Contributed by @fireairforce
+
+- [noUnusedFunctionParameters](https://biomejs.dev/linter/rules/no-unused-function-parameters/) and [noUnusedVariables](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports a parameter as unused when another parameter has a constructor type with the same parameter name ([#4227](https://github.com/biomejs/biome/issues/4227)).
+
+  In the following code, the `name` parameter is no longer reported as unused.
+
+  ```ts
+  export class Foo {
+    bar(name: string, _class: new (name: string) => any) {
+      return name
+    }
+  }
+  ```
+
+  Contributed by @Conaclos
 
 ### Parser
 

crates/biome_js_analyze/tests/specs/correctness/noUnusedFunctionParameters/issue4227.ts

@@ -0,0 +1,5 @@
+class Foo {
+    bar(name: string, _class: new (name: string) => any) {
+        return name
+    }
+}

crates/biome_js_analyze/tests/specs/correctness/noUnusedFunctionParameters/issue4227.ts.snap

@@ -0,0 +1,12 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: issue4227.ts
+---
+# Input
+```ts
+class Foo {
+    bar(name: string, _class: new (name: string) => any) {
+        return name
+    }
+}
+```

crates/biome_js_semantic/src/events.rs

@@ -439,7 +439,9 @@ impl SemanticEventExtractor {
         let node = node.syntax();
         if matches!(
             node.kind(),
-            JsSyntaxKind::TS_FUNCTION_TYPE | JsSyntaxKind::TS_MAPPED_TYPE
+            JsSyntaxKind::TS_CONSTRUCTOR_TYPE
+                | JsSyntaxKind::TS_FUNCTION_TYPE
+                | JsSyntaxKind::TS_MAPPED_TYPE
         ) {
             self.push_scope(
                 node.text_trimmed_range(),
@@ -811,7 +813,9 @@ impl SemanticEventExtractor {
         let node = node.syntax();
         if matches!(
             node.kind(),
-            JsSyntaxKind::TS_FUNCTION_TYPE | JsSyntaxKind::TS_MAPPED_TYPE
+            JsSyntaxKind::TS_CONSTRUCTOR_TYPE
+                | JsSyntaxKind::TS_FUNCTION_TYPE
+                | JsSyntaxKind::TS_MAPPED_TYPE
         ) {
             self.pop_scope(node.text_trimmed_range());
         }

crates/biome_js_semantic/src/semantic_model/builder.rs

@@ -100,6 +100,7 @@ impl SemanticModelBuilder {
             | JS_FOR_IN_STATEMENT
             | JS_SWITCH_STATEMENT
             | JS_CATCH_CLAUSE
+            | TS_CONSTRUCTOR_TYPE
             | TS_FUNCTION_TYPE
             | TS_MAPPED_TYPE => {
                 self.scope_node_by_range