fix(cli): don't handle CSS files (#1523)

biomejs · Jan 11, 2024 · 660c38a · 660c38a
1 parent 024b7af
commit 660c38a
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 ### CLI
 
 - Fix [#1512](https://github.com/biomejs/biome/issues/1512) by skipping verbose diagnostics from the count. Contributed by @ematipico
+- Don't handle CSS files, the formatter isn't ready yet. Contributed by @ematipico
 
 ### Configuration
 

diff --git a/crates/biome_cli/tests/cases/overrides_formatter.rs b/crates/biome_cli/tests/cases/overrides_formatter.rs
@@ -235,6 +235,7 @@ fn does_include_file_with_different_overrides() {
 }
 
 #[test]
+#[ignore = "Enable when we are ready to handle CSS files"]
 fn does_include_file_with_different_languages() {
     let mut console = BufferConsole::default();
     let mut fs = MemoryFileSystem::default();
@@ -291,6 +292,7 @@ fn does_include_file_with_different_languages() {
 }
 
 #[test]
+#[ignore = "Enable when we are ready to handle CSS files"]
 fn does_include_file_with_different_languages_and_files() {
     let mut console = BufferConsole::default();
     let mut fs = MemoryFileSystem::default();

diff --git a/crates/biome_cli/tests/commands/format.rs b/crates/biome_cli/tests/commands/format.rs
@@ -623,6 +623,7 @@ fn applies_custom_quote_style() {
 }
 
 #[test]
+#[ignore = "Enable when we are ready to handle CSS files"]
 fn applies_custom_css_quote_style() {
     let mut fs = MemoryFileSystem::default();
     let mut console = BufferConsole::default();

diff --git a/crates/biome_cli/tests/snapshots/main_commands_format/should_apply_different_formatting.snap b/crates/biome_cli/tests/snapshots/main_commands_format/should_apply_different_formatting.snap
@@ -33,9 +33,7 @@ expression: content
 ## `input.css`
 
 ```css
-html {
-}
-
+html {}
 ```
 
 ## `input.js`
@@ -112,7 +110,7 @@ biome.json:20:17 deserialize  DEPRECATED  ━━━━━━━━━━━━
 ```
 
 ```block
-Formatted 3 file(s) in <TIME>
+Formatted 2 file(s) in <TIME>
 ```
 
 
diff --git a/..._cli/tests/snapshots/main_commands_format/should_apply_different_formatting_with_cli.snap b/..._cli/tests/snapshots/main_commands_format/should_apply_different_formatting_with_cli.snap
@@ -15,9 +15,7 @@ expression: content
 ## `input.css`
 
 ```css
-html {
-}
-
+html {}
 ```
 
 ## `input.js`
@@ -73,7 +71,7 @@ internalError/fs  DEPRECATED  ━━━━━━━━━━━━━━━━
 ```
 
 ```block
-Formatted 3 file(s) in <TIME>
+Formatted 2 file(s) in <TIME>
 ```
 
 
diff --git a/crates/biome_service/src/file_handlers/mod.rs b/crates/biome_service/src/file_handlers/mod.rs
@@ -110,7 +110,8 @@ impl Language {
             "typescriptreact" => Language::TypeScriptReact,
             "json" => Language::Json,
             "jsonc" => Language::Jsonc,
-            "css" => Language::Css,
+            // TODO: remove this when we are ready to handle CSS files
+            "css" => Language::Unknown,
             _ => Language::Unknown,
         }
     }
@@ -341,6 +342,7 @@ pub(crate) trait ExtensionHandler {
 pub(crate) struct Features {
     js: JsFileHandler,
     json: JsonFileHandler,
+    #[allow(unused)]
     css: CssFileHandler,
     unknown: UnknownFileHandler,
 }
@@ -380,7 +382,8 @@ impl Features {
             | Language::TypeScript
             | Language::TypeScriptReact => self.js.capabilities(),
             Language::Json | Language::Jsonc => self.json.capabilities(),
-            Language::Css => self.css.capabilities(),
+            // TODO: change this when we are ready to handle CSS files
+            Language::Css => self.unknown.capabilities(),
             Language::Unknown => self.unknown.capabilities(),
         }
     }

diff --git a/website/src/content/docs/internals/changelog.mdx b/website/src/content/docs/internals/changelog.mdx
@@ -21,6 +21,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 ### CLI
 
 - Fix [#1512](https://github.com/biomejs/biome/issues/1512) by skipping verbose diagnostics from the count. Contributed by @ematipico
+- Don't handle CSS files, the formatter isn't ready yet. Contributed by @ematipico
 
 ### Configuration
-Original file line number
+Diff line change
@@ Expand Up @@
     ### CLI
     - Fix [#1512](https://github.com/biomejs/biome/issues/1512) by skipping verbose diagnostics from the count. Contributed by @ematipico
+    - Don't handle CSS files, the formatter isn't ready yet. Contributed by @ematipico
     ### Configuration
@@ Expand Down @@