refactor(lint/noUselessTypeConstraint): make code fix safe (#378)

CHANGELOG.md

@@ -51,6 +51,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 - The following rules have now safe code fixes:
 
   - [noUselessLabel](https://biomejs.dev/linter/rules/no-useless-label)
+  - [noUselessTypeConstraint](https://biomejs.dev/linter/rules/no-useless-type-constraint)
 
 #### Bug fixes
 

crates/biome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs

@@ -3,7 +3,7 @@ use biome_analyze::{declare_rule, ActionCategory, Ast, Rule, RuleDiagnostic};
 use biome_console::markup;
 
 use biome_diagnostics::Applicability;
-use biome_js_syntax::TsTypeConstraintClause;
+use biome_js_syntax::{AnyTsType, TsTypeConstraintClause};
 use biome_rowan::{AstNode, BatchMutationExt};
 
 use crate::JsRuleAction;
@@ -88,12 +88,7 @@ impl Rule for NoUselessTypeConstraint {
     fn run(ctx: &RuleContext<Self>) -> Option<Self::State> {
         let node = ctx.query();
         let ty = node.ty().ok()?;
-
-        if ty.as_ts_any_type().is_some() || ty.as_ts_unknown_type().is_some() {
-            Some(())
-        } else {
-            None
-        }
+        matches!(ty, AnyTsType::TsAnyType(_) | AnyTsType::TsUnknownType(_)).then_some(())
     }
 
     fn diagnostic(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<RuleDiagnostic> {
@@ -115,11 +110,15 @@ impl Rule for NoUselessTypeConstraint {
     fn action(ctx: &RuleContext<Self>, _state: &Self::State) -> Option<JsRuleAction> {
         let node = ctx.query();
         let mut mutation = ctx.root().begin();
+        let prev = node.syntax().prev_sibling()?;
+        mutation.replace_element_discard_trivia(
+            prev.clone().into(),
+            prev.trim_trailing_trivia()?.into(),
+        );
         mutation.remove_node(node.clone());
-
         Some(JsRuleAction {
             category: ActionCategory::QuickFix,
-            applicability: Applicability::MaybeIncorrect,
+            applicability: Applicability::Always,
             message: markup! { "Remove the constraint." }.to_owned(),
             mutation,
         })

crates/biome_js_analyze/tests/specs/complexity/noUselessTypeConstraint/invalid.ts

@@ -13,3 +13,5 @@ class BazAny<T extends any> {
 const QuuxAny = <T extends any>() => {};
 
 function QuuzAny<T extends any>() {}
+
+function commented<T /*a*/ extends /*b*/ any /*c*/>() {}

crates/biome_js_analyze/tests/specs/complexity/noUselessTypeConstraint/invalid.ts.snap

@@ -1,6 +1,5 @@
 ---
 source: crates/biome_js_analyze/tests/spec_tests.rs
-assertion_line: 96
 expression: invalid.ts
 ---
 # Input
@@ -21,6 +20,8 @@ const QuuxAny = <T extends any>() => {};
 
 function QuuzAny<T extends any>() {}
 
+function commented<T /*a*/ extends /*b*/ any /*c*/>() {}
+
 ```
 
 # Diagnostics
@@ -36,10 +37,10 @@ invalid.ts:1:21 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━
   
   i All types are subtypes of any and unknown.
   
-  i Suggested fix: Remove the constraint.
+  i Safe fix: Remove the constraint.
   
     1 │ interface·FooAny1<T·extends·any>·{
-      │                     -----------   
+      │                    ------------   
 
 ```
 
@@ -57,10 +58,10 @@ invalid.ts:5:21 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━
   
   i All types are subtypes of any and unknown.
   
-  i Suggested fix: Remove the constraint.
+  i Safe fix: Remove the constraint.
   
     5 │ interface·FooAny2<T·extends·unknown>·{
-      │                     ---------------   
+      │                    ----------------   
 
 ```
 
@@ -78,10 +79,10 @@ invalid.ts:9:16 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━
   
   i All types are subtypes of any and unknown.
   
-  i Suggested fix: Remove the constraint.
+  i Safe fix: Remove the constraint.
   
     9 │ class·BazAny<T·extends·any>·{
-      │                -----------   
+      │               ------------   
 
 ```
 
@@ -98,10 +99,10 @@ invalid.ts:10:12 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━
   
   i All types are subtypes of any and unknown.
   
-  i Suggested fix: Remove the constraint.
+  i Safe fix: Remove the constraint.
   
     10 │ ··quxAny<U·extends·any>()·{}
-       │            -----------      
+       │           ------------      
 
 ```
 
@@ -119,10 +120,10 @@ invalid.ts:13:20 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━
   
   i All types are subtypes of any and unknown.
   
-  i Suggested fix: Remove the constraint.
+  i Safe fix: Remove the constraint.
   
     13 │ const·QuuxAny·=·<T·extends·any>()·=>·{};
-       │                    -----------          
+       │                   ------------          
 
 ```
 
@@ -136,13 +137,34 @@ invalid.ts:15:20 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━
   > 15 │ function QuuzAny<T extends any>() {}
        │                    ^^^^^^^^^^^
     16 │ 
+    17 │ function commented<T /*a*/ extends /*b*/ any /*c*/>() {}
   
   i All types are subtypes of any and unknown.
   
-  i Suggested fix: Remove the constraint.
+  i Safe fix: Remove the constraint.
   
     15 │ function·QuuzAny<T·extends·any>()·{}
-       │                    -----------      
+       │                   ------------      
+
+```
+
+```
+invalid.ts:17:28 lint/complexity/noUselessTypeConstraint  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Constraining a type parameter to any or unknown is useless.
+  
+    15 │ function QuuzAny<T extends any>() {}
+    16 │ 
+  > 17 │ function commented<T /*a*/ extends /*b*/ any /*c*/>() {}
+       │                            ^^^^^^^^^^^^^^^^^
+    18 │ 
+  
+  i All types are subtypes of any and unknown.
+  
+  i Safe fix: Remove the constraint.
+  
+    17 │ function·commented<T·/*a*/·extends·/*b*/·any·/*c*/>()·{}
+       │                           ------------------------      
 
 ```
 

website/src/content/docs/internals/changelog.mdx

@@ -57,6 +57,7 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 - The following rules have now safe code fixes:
 
   - [noUselessLabel](https://biomejs.dev/linter/rules/no-useless-label)
+  - [noUselessTypeConstraint](https://biomejs.dev/linter/rules/no-useless-type-constraint)
 
 #### Bug fixes