refactor: unrecommend noDoneCallback

biomejs · Sep 12, 2024 · 0afae5a · 0afae5a
1 parent baf8eff
commit 0afae5a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/crates/biome_configuration/src/analyzer/linter/rules.rs b/crates/biome_configuration/src/analyzer/linter/rules.rs
@@ -4533,7 +4533,6 @@ impl Style {
     const RECOMMENDED_RULES: &'static [&'static str] = &[
         "noArguments",
         "noCommaOperator",
-        "noDoneCallback",
         "noInferrableTypes",
         "noNonNullAssertion",
         "noParameterAssign",
@@ -4560,7 +4559,6 @@ impl Style {
     const RECOMMENDED_RULES_AS_FILTERS: &'static [RuleFilter<'static>] = &[
         RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[0]),
         RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[1]),
-        RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[3]),
         RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[5]),
         RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[9]),
         RuleFilter::Rule(Self::GROUP_NAME, Self::GROUP_RULES[10]),

diff --git a/crates/biome_js_analyze/src/lint/style/no_done_callback.rs b/crates/biome_js_analyze/src/lint/style/no_done_callback.rs
@@ -47,7 +47,7 @@ declare_lint_rule! {
         version: "1.6.1",
         name: "noDoneCallback",
         language: "js",
-        recommended: true,
+        recommended: false,
         sources: &[RuleSource::EslintJest("no-done-callback")],
     }
 }