fix(lint/noSvgWithoutTitle): skip on aria-hidden (#928)

biomejs · Nov 28, 2023 · 01309e8 · 01309e8
1 parent 514a688
commit 01309e8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/crates/biome_js_analyze/src/analyzers/a11y/no_svg_without_title.rs b/crates/biome_js_analyze/src/analyzers/a11y/no_svg_without_title.rs
@@ -99,6 +99,15 @@ impl Rule for NoSvgWithoutTitle {
             return None;
         }
 
+        if let Some(aria_hidden_attr) = node.find_attribute_by_name("aria-hidden") {
+            if let Some(attr_static_val) = aria_hidden_attr.as_static_value() {
+                let attr_text = attr_static_val.text();
+                if attr_text == "true" {
+                    return None;
+                }
+            }
+        }
+
         // Checks if a `svg` element has a valid `title` element is in a childlist
         let jsx_element = node.parent::<JsxElement>()?;
         if let AnyJsxElement::JsxOpeningElement(_) = node {

diff --git a/crates/biome_js_analyze/tests/specs/a11y/noSvgWithoutTitle/valid.jsx b/crates/biome_js_analyze/tests/specs/a11y/noSvgWithoutTitle/valid.jsx
@@ -37,4 +37,12 @@
 		<title>implicit role</title>
 		<span>Pass</span>
 	</svg>
+
+	<svg aria-hidden="true">
+        <defs>
+          <pattern>
+            <path d="M.5 200V.5H200" fill="none" />
+          </pattern>
+        </defs>
+    </svg>
 </>;
diff --git a/crates/biome_js_analyze/tests/specs/a11y/noSvgWithoutTitle/valid.jsx.snap b/crates/biome_js_analyze/tests/specs/a11y/noSvgWithoutTitle/valid.jsx.snap
@@ -43,6 +43,14 @@ expression: valid.jsx
 		<title>implicit role</title>
 		<span>Pass</span>
 	</svg>
+
+	<svg aria-hidden="true">
+        <defs>
+          <pattern>
+            <path d="M.5 200V.5H200" fill="none" />
+          </pattern>
+        </defs>
+    </svg>
 </>;
 
 ```