Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #27

Merged
merged 3 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/EditableField.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ const EditableField = (props) => {

const onChange = (e) => {
const { value: newValueRaw } = e.target;

const newValue = formatter(newValueRaw);

if (validationFunc) {
Expand Down Expand Up @@ -104,7 +103,9 @@ const EditableField = (props) => {
aria-label='Input'
autoFocus
onChange={onChange}
onClick={(e) => e.stopPropagation()}
size='small'
draggable
defaultValue={editedValue}
onKeyDown={onKeyDown}
/>
Expand Down
4 changes: 2 additions & 2 deletions src/components/plots/helpers/heatmap/vega/generateVegaData.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { reversed } from 'utils/arrayUtils';
const generateVegaData = (
cellOrder, expressionMatrix, heatmapSettings, cellSets,
) => {
const { selectedGenes, selectedTracks, guardlines } = heatmapSettings;
const { selectedGenes, selectedTracks, guardLines } = heatmapSettings;
const trackOrder = reversed(selectedTracks);

const data = {
Expand All @@ -26,7 +26,7 @@ const generateVegaData = (
cellOrder,
rootNode,
cellSets,
guardlines,
guardLines,
),
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ const MarkerHeatmap = ({ experimentId }) => {
}

const data = generateVegaData(downsampledCellOrder, downsampledMatrix, config, cellSets);
const spec = generateSpec(config, 'Cluster ID', data, true);
const spec = generateSpec(config, 'Cluster ID', data, config.showGeneLabels);

spec.description = 'Marker heatmap';

Expand Down
Loading