Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Worker submit performance improvements try out #4

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

cosa65
Copy link

@cosa65 cosa65 commented Aug 10, 2023

Description

Details

URL to issue

hms-dbmi-cellenics/issues#17

Link to staging deployment URL (or set N/A)

https://ui-martinfosco-ui5-api4-wor1.scp-staging.biomage.net/

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@cosa65 cosa65 force-pushed the worker-speed-improvements-test branch 2 times, most recently from 13b4777 to fee58a0 Compare August 10, 2023 21:26
@cosa65 cosa65 marked this pull request as ready for review August 24, 2023 23:16
@cosa65 cosa65 force-pushed the worker-speed-improvements-test branch from 111a4a2 to 499728a Compare September 8, 2023 13:08
@cosa65 cosa65 force-pushed the worker-speed-improvements-test branch from 1a7a9bc to 89510c9 Compare September 21, 2023 17:17
Signed-off-by: cosa65 <[email protected]>
@cosa65 cosa65 merged commit 848531a into master Sep 21, 2023
@cosa65 cosa65 deleted the worker-speed-improvements-test branch September 21, 2023 18:22
cosa65 pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants