Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[128] Bugfix: Heatmap - selected genes get reset when changing group by settings #13

Merged
merged 24 commits into from
Nov 15, 2023

Conversation

cosa65
Copy link

@cosa65 cosa65 commented Oct 19, 2023

Description

Details

URL to issue

N/A
https://github.com/biomage-org/issues/issues/128

Link to staging deployment URL (or set N/A)

https://ui-martinfosco-ui39-api13-wor.scp-staging.biomage.net/

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/worker#310
hms-dbmi-cellenics#446
hms-dbmi-cellenics/ui#854

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a78c013) 90.47% compared to head (00a30d0) 90.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   90.47%   90.54%   +0.06%     
==========================================
  Files         166      166              
  Lines        3655     3679      +24     
  Branches      414      418       +4     
==========================================
+ Hits         3307     3331      +24     
  Misses        326      326              
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosa65 cosa65 force-pushed the 128-fix-selected-genes-are-lost-on-groupby-change branch from f25619f to b8e92dc Compare November 14, 2023 14:53
@cosa65 cosa65 merged commit 280af47 into master Nov 15, 2023
21 checks passed
@cosa65 cosa65 deleted the 128-fix-selected-genes-are-lost-on-groupby-change branch November 15, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants