Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Explorer: Add exact match by label #265

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 17, 2023

Issue

Fixes #264.

Description of changes

Add match by exact label.

@ajdapretnar, if this works for you, feel free to merge. There will be no tests; this widget is what it is -- largely untested. Adding a new option at the beginning (changing the indices of all options) bothered only a single test. :(

Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd assigned janezd and ajdapretnar and unassigned janezd Feb 23, 2024
@ajdapretnar
Copy link
Contributor

Ok, let's forgo testing. Do I understand correctly that these selections are not even settings, so no migration is necessary?

@janezd
Copy link
Contributor Author

janezd commented Feb 29, 2024

Ok, let's forgo testing. Do I understand correctly that these selections are not even settings, so no migration is necessary?

This is an excellent question. mark_mode is not a setting. But mark_hops (used when mode is "Mark nodes in vicinity of selection") is. On the other hand, the text that you enter for "Mark node labeled as" or "Mark nodes whose label starts with" is not even a variable but is read directly from the line edit.

Let us discuss this tomorrow.

@janezd janezd merged commit 4047242 into biolab:master Mar 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Network Explorer: add option to filter on exact node name
2 participants