Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Divide into double, not Py_ssize_t #260

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Oct 26, 2023

Issue
  • With cdivision=true, dividing two ints resulted in an int,
  • and were also stored into Py_ssize_t,
  • with the former also masking a division by zero,
  • in a place where the division was unnecessary anyway.

Luckily, this probably didn't effect the algorithm a lot.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cd58f9) 73.28% compared to head (1bf2dfd) 73.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   73.28%   73.35%   +0.06%     
==========================================
  Files          21       21              
  Lines        2976     2976              
==========================================
+ Hits         2181     2183       +2     
+ Misses        795      793       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd janezd merged commit 6cd0ee5 into biolab:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants