Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to keep un-namespaced attributes AND attributes with "cas" prefix #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nox-404
Copy link

@Nox-404 Nox-404 commented Dec 9, 2015

It will keep all attributes into extra_attributes["cas"]

@Nox-404
Copy link
Author

Nox-404 commented Dec 9, 2015

This allow rack-cas to work with CAS like the one from web2py

@adamcrown
Copy link
Collaborator

Thanks for putting the work in on this @Nox-404. I wasn't aware that web2py used CAS authentication so that's good to know.

There are enough different CAS implementations that I'm thinking I need to stop trying to have the code figure out which one is which automatically, and instead have different "plugins" for each different type of extra attributes format. So I'm thinking I'll hold off on merging this in favor of that approach.

I'll leave this open until I have a solution in place though. If it takes me a while then I'll come back and merge this in.

@Nox-404
Copy link
Author

Nox-404 commented Dec 10, 2015

Ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants