Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: new scalar filtering #398

Closed
wants to merge 61 commits into from
Closed

Draft: new scalar filtering #398

wants to merge 61 commits into from

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Jan 11, 2024

No description provided.

@biojppm biojppm marked this pull request as draft January 11, 2024 17:36
src/c4/yml/parse.cpp Fixed Show fixed Hide fixed
src/c4/yml/parse.cpp Fixed Show fixed Hide fixed
src/c4/yml/parse.cpp Fixed Show fixed Hide fixed
src/c4/yml/parse.cpp Fixed Show fixed Hide fixed
src/c4/yml/parse.cpp Dismissed Show dismissed Hide dismissed
src/c4/yml/common.hpp Dismissed Show dismissed Hide dismissed
src/c4/yml/parse.cpp Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8c1d622) 96.59% compared to head (79905ac) 96.57%.

Files Patch % Lines
src/c4/yml/parse.cpp 98.79% 6 Missing ⚠️
src/c4/yml/common.hpp 76.47% 4 Missing ⚠️
src/c4/yml/filter_processor.hpp 99.09% 2 Missing ⚠️
src/c4/yml/detail/parser_dbg.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   96.59%   96.57%   -0.02%     
==========================================
  Files          22       24       +2     
  Lines        8155     8494     +339     
==========================================
+ Hits         7877     8203     +326     
- Misses        278      291      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biojppm biojppm force-pushed the newfilter branch 2 times, most recently from 779b5c6 to 9de8779 Compare January 11, 2024 21:04
src/c4/yml/filter_processor.hpp Dismissed Show dismissed Hide dismissed
src/c4/yml/filter_processor.hpp Dismissed Show dismissed Hide dismissed
@biojppm
Copy link
Owner Author

biojppm commented Mar 26, 2024

overridden by #414 (which includes this changeset)

@biojppm biojppm closed this Mar 26, 2024
@biojppm biojppm deleted the newfilter branch March 26, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant