Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix build with C4CORE_NO_FAST_FLOAT and a typo #163

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

mbs-c
Copy link
Contributor

@mbs-c mbs-c commented Oct 20, 2021

See also biojppm/c4core#42.

Fixes #162.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #163 (d1410c3) into master (82d96e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          63       63           
  Lines       12241    12241           
=======================================
  Hits        11777    11777           
  Misses        464      464           
Impacted Files Coverage Δ
src/c4/yml/tree.cpp 94.43% <ø> (ø)
src/c4/yml/tree.hpp 98.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d96e2...d1410c3. Read the comment docs.

@biojppm
Copy link
Owner

biojppm commented Oct 20, 2021

To benefit from the fixes that you added in c4core, you should also update the c4core submodule to the commit after MR biojppm/c4core#42 . If you wish to proceed otherwise, just let me know and I will then merge.

@mbs-c
Copy link
Contributor Author

mbs-c commented Oct 20, 2021

I wasn't sure whether I should do that myself, but if you're fine with it, I'll add another commit so that this PR is logically complete.

@biojppm
Copy link
Owner

biojppm commented Oct 20, 2021

Thanks!

@biojppm biojppm merged commit 81496c8 into biojppm:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in src/c4/yml/tree.cpp
2 participants