-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported target is missing the export()
command
#53
Comments
biojppm
added a commit
to biojppm/cmake
that referenced
this issue
Dec 26, 2021
biojppm
added a commit
that referenced
this issue
Dec 26, 2021
biojppm
added a commit
to biojppm/rapidyaml
that referenced
this issue
Dec 26, 2021
biojppm
added a commit
to biojppm/rapidyaml
that referenced
this issue
Dec 27, 2021
[fix] re biojppm/c4core#53: add install exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The c4 CMake scripts automatically take care of creating the CMake config files. Based on my (ever incomplete) understanding of CMake, I think that somewhere in this process there is a missing
export()
. I have seen it done in other libraries (fmtlib, pugixml, etc.)For example, in
c4Project.cmake
:Without it, if I use rapidyaml in a library of my own and want to create an install target for my library, with exports, CMake currently complains that
This error is fixed by adding the
export()
command as above. I'm happy to create a PR to suggest the modification, but I don't know if there's perhaps a better place to do this within the c4 scripts.The text was updated successfully, but these errors were encountered: