Fix: wrong filtered gene count in 01_input_qc.html #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Gene filtering section of the generated 01_input_qc.html report, it reports a wrong number of removed filtered genes, both in custom and data-sensitive tab.
Current behaviour
It reports the number of genes that aren't discarded.
Expected behaviour
It should report the number of genes that are discarded and removed from the rest of the analysis.
Fix
The error is in
inst/Rmd/single_sample/01_input_qc_children/gene_filtering_qc.Rmd
andinst/Rmd/single_sample/01_input_qc_children/gene_filtering_custom.Rmd
. Example:scdrake/inst/Rmd/single_sample/01_input_qc_children/gene_filtering_qc.Rmd
Lines 13 to 14 in d92f86e
sce_qc_gene_filter
is a logical vector whereTRUE
is not passing the filter, andFALSE
is passing the filter. However, currently it is summing allFALSE
values = all the genes that are passing the filter. It is taking a reverse values of logical vector and summing it. The fix is removing the inversion of the logical vector.