Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve output shape validation #395

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Improve output shape validation #395

merged 3 commits into from
Feb 18, 2022

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Feb 18, 2022

as discussed in #392

constantinpape
constantinpape reviewed Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a breaking example and add a test that uses it to make sure that the issue is caught.

constantinpape
constantinpape approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, nvmd I just saw that it's there already. (You just produce the example on the fly instead of storing it; and that's fine.)

k-dominik
k-dominik approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! :)

@FynnBe FynnBe merged commit 7467bcf into main Feb 18, 2022
@FynnBe FynnBe deleted the min_shape_halo branch February 18, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

@k-dominik k-dominik k-dominik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FynnBe @constantinpape @k-dominik