-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies field for all weight formats #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
But tests are still failing because something tries to cast string to int:
bioimageio/spec/commands.py:111: in validate
"warnings": ValidationWarning.get_warning_summary(validation_warnings),
bioimageio/spec/shared/common.py:69: in get_warning_summary
add_to_summary(summary, keys, msg)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
s = {}, keys = [], msg = "missing 'pytorch_version'"
def add_to_summary(s, keys, msg):
key = keys.pop(0)
if "[" in key:
key, rest = key.split("[")
assert rest[-1] == "]"
> idx = int(rest[:-1])
E ValueError: invalid literal for int() with base 10: 'torchscript'
bioimageio/spec/shared/common.py:38: ValueError
@FynnBe the tests pass now, could you still address the 2 comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one suggestion to reformulate the doc string. Otherwise this looks good to me, feel free to merge when you think this is ready @FynnBe
Co-authored-by: Constantin Pape <[email protected]>
No description provided.