Reorganize imports #122
Reorganize imports #122
Conversation
bioimage.spec.latest.build_spec moved to bioimage.spec.build_spec
There was a problem hiding this comment.
LGTM, but I think it would be good if @FynnBe has another look at this too.
Edit: Sorry, I didn't see that this is still marked as draft, I assumed it was good to go since tests pass.
Thx @constantinpape for the review. I left it a draft because I felt it turned out a bit more complicated than I anticipated and was not sure whether it was a good idea or not. But I think we'd have similar issues with the custom finder/loader approach. Let's let @FynnBe have a look and then maybe decide. |
bioimageio/spec/__init__.py
Outdated
| # assuming schema will always be part of spec | ||
| from . import schema | ||
| from .raw_nodes import FormatVersion | ||
| __version__ = schema.get_args(FormatVersion)[-1] |
There was a problem hiding this comment.
here you are actually assuming that schema always imports typing.get_args
Did you avoid
try:
from typing import get_args
except ImportError:
from typing_extensions import get_argsher ein init.py on purpose?
There was a problem hiding this comment.
good catch. this doesn't make any sense - I'm going to move that import to spec.shared.common, and change all imports accordingly.
# Conflicts: # bioimageio/spec/latest/__init__.py # bioimageio/spec/v0_3/schema.py # bioimageio/spec/v0_3/utils.py
Summary:
bioimageio.spec.latestmodule.gen_specis moved tobioimageio.spec.v0_3. This makes thev0_3spec available frombioimage.spec.I kept this as draft, because after actually doing it, I think the approach with the script that generates those modules might be to fragile. Also I feel I would have to document it a lot, which also seems like a sign, that it's a bad idea. Maybe living with the fact that
from bioimageio.spec.raw_nodes import Somethingdoesn't work is less painful.fixes #120